feat(notification/telegram): add telegram notification #19135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
force-pushed
the
17899/telegramNotification2
branch
2 times, most recently
from
baaadc2
to
a2891ab
Compare
|
@sranka what is the status of this? have you looked into why the initial revert was made in order to avoid another? My assumption is that you will need to split this work into separate prs for the frontend and backend work, but i'm not certain |
sranka
force-pushed
the
17899/telegramNotification2
branch
from
a2891ab
to
d6f3c33
Compare
|
@glinton it was reverted because of deployment problems, a new feature flag that turns off telegram UI is the solution, the name of the flag was suggested by @desa on July, 27th :
|
ebb-tide
reviewed
Aug 7, 2020
ui/src/notifications/endpoints/components/EndpointTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
ebb-tide
reviewed
Aug 7, 2020
ebb-tide
approved these changes
Aug 7, 2020
ui/src/notifications/endpoints/components/EndpointTypeDropdown.tsx
Outdated
Show resolved
Hide resolved
…dpoint-telegram flag
sranka
force-pushed
the
17899/telegramNotification2
branch
from
d6f3c33
to
3bb7cc5
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes back the telegram notification (#18218) that was reverted by #19088 + adds a new UI feature flag
notification-endpoint-telegramthat turns on/off telegram notifications (in 04b188a), off by default