Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cell-queries-error): created mutex hashmap to resolve queries independently of one another #19188

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Aug 3, 2020

Closes #19058

Problem

Mutex instance was running one query and passing the results of that query to all queries being resolved in the cell context

Solution

Create a hashmap of query's with a mutex as the corresponding value for each cell, and set the results to the hashmap per cell.

two-queries

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested review from a team and TCL735 and removed request for a team August 3, 2020 21:09
Copy link
Contributor

@121watts 121watts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Will be great to get that in there.

@asalem1 asalem1 merged commit 5553049 into master Aug 3, 2020
@asalem1 asalem1 deleted the two-queries-bug branch August 3, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On 2.0 beta-15 graphs with two queries are not correctly showed in dashboard
3 participants