feat: add tab index to alerts page #19231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
force-pushed
the
bucky_alerts_tab_index
branch
from
f67657b
to
f0df452
Compare
hoorayimhelping
requested review from
a team,
glinton,
alexpaxton and
121watts
and removed request for
a team
drdelambre
approved these changes
Aug 5, 2020
glinton
approved these changes
Aug 6, 2020
| @@ -17,6 +17,7 @@ | |||
| import './commands' | |||
|
|
|||
| import 'cypress-pipe' | |||
| import 'cypress-plugin-tab' | |||
There was a problem hiding this comment.
js newb so ignore if not relevant, but is this import used anywhere (i assume the linter would complain if not, and that it could be used in another file)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got annoyed trying to use my keyboard to filter things on the alerts page, so I rage fixed it. You can use
tabto navigate into the filter text boxes now.