Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add TSM 1.x storage options as flags #19506

Merged
merged 6 commits into from
Sep 4, 2020
Merged

feat: Add TSM 1.x storage options as flags #19506

merged 6 commits into from
Sep 4, 2020

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Sep 4, 2020 •
edited
Loading

Closes #19505

This PR primarily is focused on adding a number of TSM / TSI engine options to the CLI interface of influxd.

In addition, it complete a little housekeeping:

  • ✅ Remove redundant replace directives from go.mod
  • ✅ Enhances toml package types to implement viper's pflag.Value interface for use a CLI arguments
  • ✅ Removes page-fault-rate flag, which is not available in TSM 1.x

@stuartcarnie stuartcarnie added the area/2.x OSS 2.0 related issues and PRs label Sep 4, 2020
@stuartcarnie stuartcarnie self-assigned this Sep 4, 2020
@stuartcarnie stuartcarnie requested a review from a team September 4, 2020 21:55
@stuartcarnie stuartcarnie merged commit 04cff2a into master Sep 4, 2020
@stuartcarnie stuartcarnie deleted the sgc/issue/19505 branch September 4, 2020 22:57
@kelseiv kelseiv mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettbuddin brettbuddin brettbuddin approved these changes

Assignees

@stuartcarnie stuartcarnie

Labels
area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide CLI access to storage configuration
2 participants
@stuartcarnie @brettbuddin