Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow empty database name, closes #1950 #1955

Merged
merged 2 commits into from
Mar 14, 2015

Conversation

dullgiulio
Copy link
Contributor

As reported in #1950, disallow empty database names in both DB creation and JSON unmarshalling.

@otoolep
Copy link
Contributor

otoolep commented Mar 14, 2015

Changes look good @dullgiulio -- can you make the extra changes I suggested, and sign the CLA?

@dullgiulio
Copy link
Contributor Author

Sure, here you go. Also signed the CLA.

@@ -321,6 +326,11 @@ func TestServer_DropDatabase(t *testing.T) {
s := OpenServer(NewMessagingClient())
defer s.Close()

// Attempt creating empty name database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: comment is not quite right.

@otoolep
Copy link
Contributor

otoolep commented Mar 14, 2015

Thanks @dullgiulio -- I will merge.

otoolep added a commit that referenced this pull request Mar 14, 2015
do not allow empty database name, closes #1950
@otoolep otoolep merged commit 9723d3f into influxdata:master Mar 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants