Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): don't accept short passwords in setup #19593

Merged
merged 7 commits into from
Sep 29, 2020
Merged

fix(cli): don't accept short passwords in setup #19593

merged 7 commits into from
Sep 29, 2020

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Sep 18, 2020

Addresses #19585

Error if influx setup is called and a password shorter than 8 characters is specified.

This reverts commit 77c4bba because it appears (from the tests) that an empty password is intended. Deferring these changes to API owners.
@glinton glinton marked this pull request as ready for review September 21, 2020 23:27
@glinton glinton requested review from a team and asalem1 and removed request for a team September 22, 2020 16:15
Copy link
Contributor

@asalem1 asalem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you happen to speak to @121watts about this? I think he made a similar change a while back and it lead to some unforeseen issues

cmd/influx/setup.go Outdated Show resolved Hide resolved
@glinton glinton requested a review from a team September 29, 2020 22:13
Copy link
Contributor

@asalem1 asalem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🤞🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants