Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typos in http/swagger.yml #19834

Merged
merged 1 commit into from
Oct 27, 2020
Merged

docs: Fix typos in http/swagger.yml #19834

merged 1 commit into from
Oct 27, 2020

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented Oct 27, 2020 •
edited
Loading

@pierwill pierwill requested a review from a team as a code owner October 27, 2020 17:26
@pierwill pierwill requested review from kristinarobinson and removed request for a team October 27, 2020 17:26
hoorayimhelping
hoorayimhelping approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than most stuff on the internet these days

@pierwill
Copy link
Contributor Author

pierwill commented Oct 27, 2020 •
edited
Loading

Lol @hoorayimhelping thanks. :)

Can I merge this with the tests failing?

@pierwill pierwill mentioned this pull request Oct 27, 2020
Open
@pierwill
Copy link
Contributor Author

Not sure how to diagnose the circleci e2e issue.

@hoorayimhelping
Copy link
Contributor

@pierwill i'm seeing all greens, did you (or someone) rebuild? for posterity, that's probably the most expedient way to address e2e tests

@pierwill
Copy link
Contributor Author

Looks like a fairy came by and fixed this. Thanks @hoorayimhelping, will do in the future. Merging!

@pierwill pierwill merged commit 491b7b4 into master Oct 27, 2020
@pierwill pierwill deleted the swagger-typos branch October 27, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@russorat russorat Awaiting requested review from russorat

@kristinarobinson kristinarobinson Awaiting requested review from kristinarobinson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierwill @hoorayimhelping @121watts