Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update generate ticks into an array of properties for each axis #19850

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Oct 29, 2020

Follow-up to #19839 - we need to separate the control of the tick generation for each axis, as there will be cases where a user wants to control tick generation on one axis but not both. Also, the property should be an array of strings due to Giraffe's extreme flexibility in its configuration. (Giraffe uses 3 properties to control the tick generation, and any combination of the 3 properties including being missing or null works in the config.) To capture this flexibility for the user, we save the properties selected by the user in an array of strings.

Also, removed the tick generation properties from CheckView everywhere to match the swagger.yml

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@TCL735 TCL735 requested review from a team as code owners October 29, 2020 03:09
@TCL735 TCL735 requested review from Palakp41 and glinton and removed request for a team October 29, 2020 03:09
@TCL735
Copy link
Contributor Author

TCL735 commented Oct 29, 2020

Ready for review.

@TCL735 TCL735 merged commit f6a26ee into master Oct 29, 2020
@TCL735 TCL735 deleted the feat_giraffe_79_separate_axes branch October 29, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants