Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating v1 auth description #19947

Merged
merged 3 commits into from
Nov 9, 2020
Merged

fix: updating v1 auth description #19947

merged 3 commits into from
Nov 9, 2020

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Nov 9, 2020

Closes #

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

danxmoran
danxmoran approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@russorat russorat merged commit cae5390 into master Nov 9, 2020
@russorat russorat deleted the v1-aut-desc branch November 9, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

@psteinbachs psteinbachs Awaiting requested review from psteinbachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russorat @danxmoran