Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct various typos #19987

Merged
merged 4 commits into from
Nov 11, 2020
Merged

fix: correct various typos #19987

merged 4 commits into from
Nov 11, 2020

Conversation

danxmoran
Copy link
Contributor

@danxmoran danxmoran commented Nov 11, 2020 •
edited
Loading

Rebased version of #19751 (wasn't able to push changes directly to that PR)

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@danxmoran danxmoran requested a review from a team as a code owner November 11, 2020 14:34
@danxmoran danxmoran mentioned this pull request Nov 11, 2020
Closed
8 tasks
@psteinbachs psteinbachs self-requested a review November 11, 2020 17:15
psteinbachs
psteinbachs approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@psteinbachs psteinbachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to fix the rebasing issues and addresses the UI dashboard compat. Good to go.

@danxmoran danxmoran merged commit 15b9531 into master Nov 11, 2020
@danxmoran danxmoran deleted the kumakichi/master branch November 11, 2020 18:54
danxmoran added a commit that referenced this pull request Nov 11, 2020
@danxmoran @kumakichi
fix: correct various typos (#19987)
bb13ff1 

Co-authored-by: kumakichi <xyesan@gmail.com>
danxmoran added a commit that referenced this pull request Nov 11, 2020
@danxmoran @kumakichi
fix: correct various typos (#19987)
8587efb 
Co-authored-by: kumakichi <xyesan@gmail.com>
@danxmoran danxmoran mentioned this pull request Nov 11, 2020
Merged
8 tasks
danxmoran added a commit that referenced this pull request Nov 11, 2020
@danxmoran @kumakichi
fix: correct various typos (#19987)
868a496 
Co-authored-by: kumakichi <xyesan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinbachs psteinbachs psteinbachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danxmoran @psteinbachs @kumakichi