Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): Add same site strict flag to session cookie #20015

Merged
merged 1 commit into from
Nov 13, 2020
Merged

fix(http): Add same site strict flag to session cookie #20015

merged 1 commit into from
Nov 13, 2020

Conversation

pierwill
Copy link
Contributor

@pierwill pierwill commented Nov 12, 2020 •
edited
Loading

glinton
glinton suggested changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in this pr, it would be great to document why strict mode was chosen over lax.

http/session_handler.go Outdated Show resolved Hide resolved
glinton
glinton approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still say document why you chose "strict" over "lax" for posterity's sake (ideally it would be configurable to suit individual user's needs 🤔)

@pierwill
Copy link
Contributor Author

Using "strict" here because it is more restrictive.

@pierwill pierwill merged commit aa1cefa into master Nov 13, 2020
@pierwill pierwill deleted the session-handler-samesite branch November 13, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glinton glinton glinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierwill @glinton