Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't include duplicates for SHOW DATABASES #20017

Merged
merged 6 commits into from
Nov 16, 2020
Merged

fix: Don't include duplicates for SHOW DATABASES #20017

merged 6 commits into from
Nov 16, 2020

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Nov 13, 2020 •
edited
Loading

Closes #19984

This PR ensures correct behaviour of SHOW DATABASES, such that it does not return duplicates for the same database name. Unit tests were added to verify this expectation.

Requires #20004

@stuartcarnie stuartcarnie added the area/2.x OSS 2.0 related issues and PRs label Nov 13, 2020
@stuartcarnie stuartcarnie self-assigned this Nov 13, 2020
@stuartcarnie stuartcarnie changed the title fix(influxql): Track seen databases in map and skip duplicates fix(influxql): Remove duplicates for SHOW DATABASES Nov 13, 2020
@stuartcarnie stuartcarnie changed the title fix(influxql): Remove duplicates for SHOW DATABASES fix: Remove duplicates for SHOW DATABASES Nov 13, 2020
@stuartcarnie stuartcarnie changed the title fix: Remove duplicates for SHOW DATABASES fix: Don't include duplicates for SHOW DATABASES Nov 13, 2020
@stuartcarnie stuartcarnie force-pushed the sgc/issues/19984 branch 2 times, most recently from bb67b3d to e17cfb4 Compare November 13, 2020 03:26
danxmoran
danxmoran approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and test LGTM, one question about the helpers

influxql/_v1tests/server_helpers.go Outdated Show resolved Hide resolved
@kelseiv kelseiv mentioned this pull request Nov 16, 2020
Closed
16 tasks
Base automatically changed from sgc/issues/19998-3 to master November 16, 2020 21:15
danxmoran
danxmoran approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks for fixing the build!

@stuartcarnie stuartcarnie merged commit 5d734a3 into master Nov 16, 2020
@stuartcarnie stuartcarnie deleted the sgc/issues/19984 branch November 16, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

Assignees

@stuartcarnie stuartcarnie

Labels
area/2.x OSS 2.0 related issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SHOW DATABASES returns duplicates
2 participants
@stuartcarnie @danxmoran