-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: backport master to 2.0 #20072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit will be re-added in a later patch, to restore history to the correct order.
This commit fixes a locking issue that caused the `TestShard_WritePoints_FieldConflictConcurrent` test to fail.
This resolves observed race conditions when running test suites that utilize the launcher. It also reduces test times considerably, by eliminating a slow loop to find a port.
This includes removal of a lot of kv.Service responsibilities. However, it does not finish the re-wiring. It removes documents, telegrafs, notification rules + endpoints, checks, orgs, users, buckets, passwords, urms, labels and authorizations. There are some oustanding pieces that are needed to get kv service compiling (dashboard service urm dependency). Then all the call sites for kv service need updating and the new implementations of telegraf and notification rules + endpoints needed installing (along with any necessary migrations).
I have it on good authority this is going away (or is being updated to not make the same assertions) in a upcoming PR. The way dashboards load templates has changed and it no longer relies on needing to POST to the templates endpoint. So the way this test is structured is void.
This package provides essentially the same API as the Cloud tests package, utilising the `TestLauncher` type. Additional With functional options were added to the `Launcher` in order to expose type-safe configuration of InfluxQL configuration. Additional With options may be added in the future as the need arises.
This commit copies over the comprehensive tests from Cloud.
This is useful for validating InfluxQL DDL queries that don't typically require writes or may have more complex setup requirements.
Co-authored-by: Daniel Moran <danxmoran@gmail.com>
danxmoran
force-pushed
the
dm-backport-202
branch
from
November 17, 2020 18:47
45408ea
to
6536154
Compare
danxmoran
commented
Nov 17, 2020
Co-authored-by: Dan Moran <dmoran@influxdata.com>
This was
linked to
issues
Nov 17, 2020
psteinbachs
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good.
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19981
Closes #20030
Closes #20032
Closes #20038
Closes #20068
Probably the best way to view this PR is the diff between it and master: