fix: enforce bounds on query-related CLI/config parameters to avoid startup panics #20149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-query-concurrency-max-20144
branch
2 times, most recently
from
ead83ba
to
10db735
Compare
davidby-influx
previously approved these changes
Nov 23, 2020
danxmoran
force-pushed
the
dm-query-concurrency-max-20144
branch
from
10db735
to
c86d666
Compare
danxmoran
commented
Nov 24, 2020
| @@ -34,7 +36,6 @@ want to use the default. | |||
| 1. [20053](https://github.com/influxdata/influxdb/pull/20053): Upgrade Flux to v0.95.0. | |||
| 1. [20058](https://github.com/influxdata/influxdb/pull/20058): UI: Upgrade flux-lsp-browser to v0.5.23. | |||
| 1. [20067](https://github.com/influxdata/influxdb/pull/20067): Add DBRP cli commands as `influxd v1 dbrp`. | |||
| 1. [20097](https://github.com/influxdata/influxdb/pull/20097): Ensure Index.Walk fetches matching foreign keys only. | |||
There was a problem hiding this comment.
Accidentally filed under the wrong release
danxmoran
dismissed
davidby-influx’s stale review
Extensive changes, worth another look
danxmoran
force-pushed
the
dm-query-concurrency-max-20144
branch
from
744d01d
to
ba10539
Compare
danxmoran
changed the title
davidby-influx
approved these changes
Nov 24, 2020
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20144
math.MaxInt32is the biggest value that theWaitGroupwrapped in the query controller will accept without panicking. When I try runninginfluxdwith that parameter it takes a loooooong time to boot up, but I assume it'd be faster on a beefed-up VM.