Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve v2 packaging #20305

Merged
merged 5 commits into from
Dec 14, 2020
Merged

fix: Improve v2 packaging #20305

merged 5 commits into from
Dec 14, 2020

Conversation

psteinbachs
Copy link
Contributor

@psteinbachs psteinbachs commented Dec 10, 2020

Packaging changes:

  • Package name is now influxdb2 and conflicts with any previous influxdb package (including initial 2.0.0, 2.0.1, and 2.0.2 packages)
    • Requires explicit removal of previous package before installing new package
  • Creates an /etc/default/influxdb2 file if non existent, which sets environment defaults
    • INFLUXD_CONFIG_PATH=/etc/influxdb/config.toml
    • INFLUXD_BOLT_PATH=/var/lib/influxd/influxd.bolt
    • INFLUXD_ENGINE_PATH=/var/lib/influxdb/engine
  • Systemd service file now reads /etc/default/influxdb2
  • Detects if v2 directory structure/files exist and outputs upgrade message if not
  • Generates an upgrade script under /usr/share/influxdb/influxdb2-upgrade.sh
    • Runs 'influxd upgrade' with appropriate arguments
    • If exit code successful, outputs a message about further steps, v1 cleanup via helper script
    • If exit code unsuccessful, outputs a message about further steps, v2 cleanup via helper script

scripts/influxdb2-upgrade.sh Outdated Show resolved Hide resolved
scripts/influxdb2-upgrade.sh Show resolved Hide resolved
scripts/influxdb2-upgrade.sh Show resolved Hide resolved
@danxmoran
Copy link
Contributor

Should we include this in CHANGELOG.md? For the ARM build I made a top-level callout, we could maybe broaden it to something like "packaging changes"

CHANGELOG.md Outdated Show resolved Hide resolved
scripts/influxdb2-upgrade.sh Show resolved Hide resolved
scripts/influxdb2-upgrade.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants