fix(tsdb): never use an inmem index #20313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartcarnie could you take a look at this one? I'm pretty confident the existing gotests cover the logic (many were failing when I still had bugs in |
dgnorton
previously requested changes
Dec 14, 2020
|
Other note from Zoom review: try to add an integration test to check that index files are (re)generated if missing, and that query results are the same. |
danxmoran
commented
Dec 14, 2020
danxmoran
force-pushed
the
dm-no-inmem-index-20257
branch
from
10b9413
to
192c178
Compare
danxmoran
commented
Dec 16, 2020
danxmoran
force-pushed
the
dm-no-inmem-index-20257
branch
from
c68e769
to
0e58f48
Compare
danxmoran
force-pushed
the
dm-no-inmem-index-20257
branch
from
0e58f48
to
a7ecd1b
Compare
danxmoran
commented
Dec 22, 2020
| if pw, ok := e.pointsWriter.(*coordinator.PointsWriter); ok { | ||
| pw.Logger = e.logger | ||
| pw.WithLogger(e.logger) |
There was a problem hiding this comment.
Drive-by fix for engine logging setup
stuartcarnie
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Great work, @danxmoran – removing this will simplify future maintenance of the TSDB engine. 🥇 👏 🧹
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20257
2.x was never meant to use an inmem index, but there was a fallback code path to handle cases when
influxd upgradedidn't convert an inmem index into TSI. All code for the inmem index is now deleted, and the fallback is replaced by a one-time reindex operation run on shards w/o a TSI directory.The reindex logic is inspired by the
influx inspectimplementation, but uses methods onEngineto read TSM / WAL data instead of listing and reading files directly from the file system.