Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dictionaries to the swagger ast specification #20360

Merged
merged 1 commit into from
Dec 17, 2020
Merged

chore: add dictionaries to the swagger ast specification #20360

merged 1 commit into from
Dec 17, 2020

Conversation

jpacik
Copy link
Contributor

@jpacik jpacik commented Dec 16, 2020

Closes #20299

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Feature flagged (if modified API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@jpacik jpacik requested review from a team and nathanielc and removed request for a team December 17, 2020 18:02
nathanielc
nathanielc suggested changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@nathanielc nathanielc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

http/swagger.yml Outdated Show resolved Hide resolved
@jpacik jpacik merged commit baa3fba into master Dec 17, 2020
@jpacik jpacik deleted the chore/swagger-ast branch December 17, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielc nathanielc nathanielc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update swagger doc with new dictionary expressions
2 participants
@jpacik @nathanielc