Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dbrp): improve DBRP API validation errors #20409

Merged
merged 3 commits into from
Jan 7, 2021

Conversation

danxmoran
Copy link
Contributor

Closes #20134

@danxmoran danxmoran force-pushed the dm-improve-dbrp-validation-err-20134 branch 2 times, most recently from b3dd576 to d46208e Compare December 23, 2020 21:52
@danxmoran danxmoran force-pushed the dm-improve-dbrp-validation-err-20134 branch from d46208e to 5889ddb Compare January 6, 2021 21:38
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks helpful for debugging!

}
}

// ErrInvalidBucketID returns a more informative error about a failure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions below are nice - definitely helpful to provide more info.

@danxmoran danxmoran force-pushed the dm-improve-dbrp-validation-err-20134 branch 2 times, most recently from 93ad207 to 2ff3805 Compare January 7, 2021 15:36
@danxmoran danxmoran force-pushed the dm-improve-dbrp-validation-err-20134 branch from 2ff3805 to 6a515da Compare January 7, 2021 16:09
@danxmoran danxmoran merged commit c708eea into master Jan 7, 2021
@danxmoran danxmoran deleted the dm-improve-dbrp-validation-err-20134 branch January 7, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve validation error messages for DBRP API
2 participants