fix(tsdb): allow backups during snapshotting, and don't leak tmp files #20527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Jan 16, 2021
| @@ -46,6 +46,8 @@ Replacement `tsi1` indexes will be automatically generated on startup for shards | |||
| 1. [20409](https://github.com/influxdata/influxdb/pull/20409): Improve messages in DBRP API validation errors. | |||
| 1. [20489](https://github.com/influxdata/influxdb/pull/20489): Improve error message when opening BoltDB with unsupported file system options. | |||
| 1. [20490](https://github.com/influxdata/influxdb/pull/20490): Fix silent failure to register CLI args as required. | |||
| 1. [20527](https://github.com/influxdata/influxdb/pull/20527): Don't leak .tmp files while backing up shards. | |||
| 1. [20527](https://github.com/influxdata/influxdb/pull/20527): Allow backups to complete while a snapshot is in progress. | |||
There was a problem hiding this comment.
Are these 2 lines an accurate summary of the expected impact?
There was a problem hiding this comment.
I think they are close enough. Sorry for no squash/merge on the original commits.
danxmoran
force-pushed
the
dm-port-backup-fixes-20526
branch
from
d819785
to
4a5b722
Compare
davidby-influx
approved these changes
Jan 16, 2021
| @@ -46,6 +46,8 @@ Replacement `tsi1` indexes will be automatically generated on startup for shards | |||
| 1. [20409](https://github.com/influxdata/influxdb/pull/20409): Improve messages in DBRP API validation errors. | |||
| 1. [20489](https://github.com/influxdata/influxdb/pull/20489): Improve error message when opening BoltDB with unsupported file system options. | |||
| 1. [20490](https://github.com/influxdata/influxdb/pull/20490): Fix silent failure to register CLI args as required. | |||
| 1. [20527](https://github.com/influxdata/influxdb/pull/20527): Don't leak .tmp files while backing up shards. | |||
| 1. [20527](https://github.com/influxdata/influxdb/pull/20527): Allow backups to complete while a snapshot is in progress. | |||
There was a problem hiding this comment.
I think they are close enough. Sorry for no squash/merge on the original commits.
Co-authored-by: davidby-influx <dbyrne@influxdata.com>
danxmoran
force-pushed
the
dm-port-backup-fixes-20526
branch
from
4a5b722
to
1389264
Compare
This was referenced Jan 19, 2021
This was referenced Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20526
Backports the end combination of #19869 and #20063, which I believe were the relevant PRs in 1.x.