Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clientLibs): add Swift library to UI #20621

Merged
merged 7 commits into from
Feb 9, 2021
Merged

feat(clientLibs): add Swift library to UI #20621

merged 7 commits into from
Feb 9, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jan 27, 2021

  1. add Swift client library

The swiftLogo.svg is a placeholder for real logo.

Screenshot 2021-01-28 at 11 53 43

Screenshot 2021-01-28 at 11 54 07

@bednar bednar changed the title feat(clientLibs): add skeleton for Swift library feat(clientLibs): add Swift library to UI Jan 27, 2021
Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
Signed-off-by: Jakub Bednar <jakub.bednar@gmail.com>
@bednar bednar marked this pull request as ready for review January 29, 2021 08:14
@bednar bednar requested review from bonitoo-builder, a team, ShmuelLotman and russorat and removed request for a team, bonitoo-builder and ShmuelLotman January 29, 2021 08:15
@russorat
Copy link
Contributor

russorat commented Feb 8, 2021

preview of the updated swift logo

image

Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, @bednar can you add a line to CHANGELOG.md?

@russorat
Copy link
Contributor

russorat commented Feb 9, 2021

@danxmoran added changelog

Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll turn the knobs on my end to make CI happy, thanks!

@danxmoran danxmoran merged commit 262cdba into influxdata:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants