fix(cmd/influx): allow for creating users without initial passwords in influx user create
#20657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
approved these changes
Feb 1, 2021
cmd/influx/user.go
Outdated
| pass := b.password | ||
| if orgID == 0 && pass == "" { | ||
| return b.printUser(userPrintOpts{user: user}) | ||
| orgID, setOrgErr := b.org.getID(dep.orgSvc) |
There was a problem hiding this comment.
Do we want to bail earlier (i.e., here) if setPassErr != nil, and not try to set the Org?
There was a problem hiding this comment.
I'll restore the previous bail-out order (org first if ID is specified, then password). Better to not rock the boat too much on a patch release.
cmd/influx/user.go
Outdated
| } | ||
|
|
||
| if pass != "" && orgID == 0 { | ||
| return errors.New("an org id is required when providing a user password") | ||
| if setPassErr != nil { |
There was a problem hiding this comment.
Consider moving this above the attempt to set the organization.
danxmoran
force-pushed
the
dm-create-user-with-password-20645
branch
2 times, most recently
from
152298d
to
7945461
Compare
danxmoran
changed the title
influx user create
danxmoran
force-pushed
the
dm-create-user-with-password-20645
branch
from
c256321
to
a03324e
Compare
davidby-influx
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20645
I manually tested the case of setting a password without specifying an org, it's tough to unit-test because the org-flag helpers are coded to read a global config file as a fallback when no flags are passed in.