feat(fluxtest): add support for testing/expect planner rules #20662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
requested review from
a team and
scbrickley
and removed request for
a team
jsternberg
force-pushed
the
feat/expect-planner-rules
branch
from
039f488
to
f16da6d
Compare
scbrickley
reviewed
Feb 1, 2021
Comment on lines
-117
to
-120
| // Use testing.inspect call to get all of diff, want, and got | ||
| inspectCalls := stdlib.TestingInspectCalls(pkg) | ||
| pkg.Files = append(pkg.Files, inspectCalls) | ||
|
|
There was a problem hiding this comment.
Could you explain why these lines are no longer necessary?
There was a problem hiding this comment.
They were an error to include. The testcase statement doesn't use these. This call is only used for the test statement and so when there are no test statements this produces an invalid file.
jsternberg
force-pushed
the
feat/expect-planner-rules
branch
from
f16da6d
to
3b69c70
Compare
scbrickley
approved these changes
Feb 1, 2021
jsternberg
force-pushed
the
feat/expect-planner-rules
branch
from
cf0b8b0
to
7017bea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3336.