fix(write): drop empty lines from write batches #20669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesam
reviewed
Feb 2, 2021
lesam
reviewed
Feb 2, 2021
| if !cmp.Equal(got, tt.want) { | ||
| t.Errorf("%q. Batcher.write() = -got/+want %s", tt.name, cmp.Diff(got, tt.want)) | ||
| } | ||
| require.Equal(t, tt.wantNoCall, !writeCalled) |
There was a problem hiding this comment.
nitpick: This logic would be a bit prettier if this had been called wantCall
There was a problem hiding this comment.
True! I like wantNoCall because the zero value is the most common case, so we can leave it unspecified in most of the test-case structs & reduce noise.
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20667
The 2nd commit is unrelated, but useful for having Support test with binaries built from branches.