feat(http): allow for disabling pprof #20827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
commented
Mar 2, 2021
| if opts.PprofEnabled { | ||
| // add profiling routes | ||
| router.GET("/debug/pprof/:thing", http.DefaultServeMux.ServeHTTP) | ||
| } |
There was a problem hiding this comment.
AFAIK this mux isn't actually connected to anything, so this is just cleanup/consolidation
danxmoran
force-pushed
the
dm-pprof-toggle-20764
branch
2 times, most recently
from
9e95391
to
00c710d
Compare
danxmoran
force-pushed
the
dm-pprof-toggle-20764
branch
from
00c710d
to
88d9d0c
Compare
danxmoran
commented
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20764
The big chunks of new logic are the
/allprofile, ported from 1.x. I didn't port the pieces of that code that gathered InfluxQL statistics, since we have other endpoints & tooling for scraping that info.As a side-effect of switching away from using the default Mux, the
/debug/varsendpoint is no longer exposed. Those vars were mostly empty in 2.x since we turned off the internal diagnostics service. The/metricsendpoint is the intended replacement.