feat(http): add config parameters for HTTP timeouts

[danxmoran]

Closes #20769

I left the defaults for the read- and write-timeout parameters as 0, as I assume those will be workload-dependent.

[danxmoran]

Moved this to be with the other HTTP params

[lesam]

Isn't IdleTimeout an implicit upper bound on the Read/Write timeouts?

Also how does this interact with the query timeout?

[danxmoran]

As I understand it, IdleTimeout is separate from read/write. It tracks the time between when a response is sent and the next request arrives.

I left read&write timeouts un-set to avoid breaking existing workloads that write huge payloads / run long-running queries. I could set them to something huge like time.Hour if we're comfortable assuming nobody would ever want to run a legit request that takes that long.

As far as I've seen, 2.x doesn't have a specific query-timeout (or any other request-specific timeouts). It would be good to restore those options at some point.

[danxmoran]

I used these 2 posts as a reference for understanding Go's timeout parameters:

• https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/
• https://ieftimov.com/post/make-resilient-golang-net-http-servers-using-timeouts-deadlines-context-cancellation/

[lesam]

You're right, I was looking at the wrong set of docs.

[lesam]

I agree explicit query timeouts would be nice - but we don't want too many knobs that interact in weird ways.