feat: port influx inspect dumptsi subcommand
#21784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgnorton
approved these changes
Jul 2, 2021
danxmoran
reviewed
Jul 2, 2021
danxmoran
reviewed
Jul 2, 2021
| defer fs.Release() | ||
| defer fs.Close() | ||
| } | ||
| defer idx.Close() |
There was a problem hiding this comment.
I think this needs to be wrapped in an if idx != nil, it looks like it'll be nil if fs != nil
serenibyss
force-pushed
the
inspect-dump-tsi
branch
from
0432e89
to
3a1575c
Compare
danxmoran
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19531
Ports the
./influx inspect dumptsisubcommand to 2.x.