Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port influx inspect report-tsm to 2.x #21814

Merged
merged 6 commits into from
Jul 20, 2021
Merged

feat: port influx inspect report-tsm to 2.x #21814

merged 6 commits into from
Jul 20, 2021

Conversation

serenibyss
Copy link
Contributor

@serenibyss serenibyss commented Jul 8, 2021 •
edited
Loading

Closes #19534

danxmoran
danxmoran reviewed Jul 9, 2021
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to CHANGELOG as well

cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/report_tsm/report_tsm.go Show resolved Hide resolved
danxmoran
danxmoran approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final naming suggestion, then LGTM

@serenibyss serenibyss merged commit 0136c7e into master Jul 20, 2021
@serenibyss serenibyss deleted the report-tsm branch July 20, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxmoran danxmoran danxmoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port influxd inspect report-tsm command
2 participants
@serenibyss @danxmoran