Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create influxd inspect verify-wal command #21828

Merged
merged 7 commits into from
Jul 15, 2021
Merged

feat: create influxd inspect verify-wal command #21828

merged 7 commits into from
Jul 15, 2021

Conversation

serenibyss
Copy link
Contributor

@serenibyss serenibyss commented Jul 9, 2021

Closes #19539

This PR creates the ./influxd inspect verify-wal subcommand. I created test cases which give about 93% coverage of the command file, only skipping basic error handling like os failing to open a file.

@danxmoran danxmoran self-requested a review July 13, 2021 18:09
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
Copy link
Contributor

@danxmoran danxmoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more suggestion from local testing, LGTM once addressed

cmd/influxd/inspect/verify_wal/verify_wal.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create influxd inspect verify-wal command
2 participants