fix: return 404 instead of links page on bad /api/v2 requests #21950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21620
In the
APIHandler, theserveLinksHandleris incorporated usingh.Mount. This causes any arbitrary requests to a subpath of/api/v2to hit theserveLinksHandler, for example/api/v2/anyrandomthing, or something more confusing like/api/v2/query&foo=barwhere the correct request should look like/api/v2/query?foo=bar. These invalid requests will return a successful status code currently.Changing
h.Mounttoh.Handlefixes this, so that only requests specifically made to/api/v2(or/api/v2/) will return the links page. Invalid requests will return a 404 Not Found.This will also help with #21167
See equivalent PR in IDPE: https://github.com/influxdata/idpe/pull/9069