feat: add --flux-log-enabled flag for detailed flux logs
#22072
Conversation
http/query_handler.go
Outdated
|
|
||
| } | ||
|
|
||
| func (h *FluxHandler) logFluxQuery(n int64, stats flux.Statistics, compiler lang.FluxCompiler, err error) { |
There was a problem hiding this comment.
Very nearly a 1:1 copy of the equivalent 1.x code, see:
influxdb/services/httpd/handler.go
Line 1442 in 444c22b
http/query_handler.go
Outdated
|
|
||
| // Detailed logging for flux queries if enabled | ||
| if h.FluxLogEnabled { | ||
| c, ok := req.Request.Compiler.(lang.FluxCompiler) |
There was a problem hiding this comment.
I don't think we need this type assertion?
There was a problem hiding this comment.
I needed to get the interface into the lang.FluxCompiler struct to access the Query property in the logFluxQuery method.
There was a problem hiding this comment.
instead of logging an error, could we just set the query string as 'unknown' if Compiler doesn't havea Query accessor?
There was a problem hiding this comment.
Pushed a change along those lines...still has the type assertion but will set the query string to 'unknown' if for some reason the underlying type of Compiler isn't a lang.FluxCompiler. This is now more similar 1.x logging function, which uses a type switch. An assertion seems to make more sense, since there is only the one type that we expect for this.
williamhbaker
force-pushed
the
wb-enable-flux-log-22071
branch
from
c0d8d7f
to
370d9bf
Compare
Closes #22071
Adds a flag
--flux-log-enabledwhich when active will show detailed logs for flux queries.