-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) support dropping server from the cluster #2234
Conversation
|
||
// RequiredPrivileges returns the privilege required to execute a DropServerStatement. | ||
func (s *DropServerStatement) RequiredPrivileges() ExecutionPrivileges { | ||
return ExecutionPrivileges{{Name: "", Privilege: AllPrivileges}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does AllPrivileges
actually mean? Means I have to have that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AllPrivileges
means privileges to do anything on the cluster.
Generally makes sense, but I don't see the value of allowing base and bit-size control of that new function. |
@otoolep We have to have two separate functions if we don't allow the |
OK, thanks @dgnorton -- perhaps allow bit-size, but not base? |
f72a963
to
a7be22f
Compare
8fa16cf
to
ae798f2
Compare
ae798f2
to
659904e
Compare
…ode.dropAndExit requires config because Broker.close and DataNode.close erase their path.
applyDropServer: can't lock because our caller already holds a lock. Node.dropAndExit requires config because the Broker and DataNode (Server) Close methods erase their path.
e6a5538
to
7d8c304
Compare
Branch merge history corrupted and unable to use git to fix. Closed and re-opened in new branch as #2486 |
Issue #1471