(WIP) support dropping server from the cluster #2234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // RequiredPrivileges returns the privilege required to execute a DropServerStatement. | ||
| func (s *DropServerStatement) RequiredPrivileges() ExecutionPrivileges { | ||
| return ExecutionPrivileges{{Name: "", Privilege: AllPrivileges}} |
There was a problem hiding this comment.
What does AllPrivileges actually mean? Means I have to have that?
There was a problem hiding this comment.
AllPrivileges means privileges to do anything on the cluster.
|
Generally makes sense, but I don't see the value of allowing base and bit-size control of that new function. |
|
@otoolep We have to have two separate functions if we don't allow the |
|
OK, thanks @dgnorton -- perhaps allow bit-size, but not base? |
corylanou
force-pushed
the
fix-1471
branch
2 times, most recently
from
f72a963
to
a7be22f
Compare
influxdb-denver-pair
force-pushed
the
fix-1471
branch
from
8fa16cf
to
ae798f2
Compare
influxdb-denver-pair
force-pushed
the
fix-1471
branch
from
ae798f2
to
659904e
Compare
…ode.dropAndExit requires config because Broker.close and DataNode.close erase their path.
applyDropServer: can't lock because our caller already holds a lock. Node.dropAndExit requires config because the Broker and DataNode (Server) Close methods erase their path.
influxdb-denver-pair
force-pushed
the
fix-1471
branch
from
e6a5538
to
7d8c304
Compare
|
Branch merge history corrupted and unable to use git to fix. Closed and re-opened in new branch as #2486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1471