add test for large mean aggregations #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neonstalwart
force-pushed
the
running-mean
branch
from
bd52c3b
to
aa3683c
Compare
neonstalwart
force-pushed
the
running-mean
branch
from
aa3683c
to
b2b6053
Compare
|
@neonstalwart this is a smart change. i think this was how means were getting calculated in v0.8.x, but it was rewritten for the new query engine architecture. |
| @@ -211,29 +211,31 @@ func MapMean(itr Iterator) interface{} { | |||
|
|
|||
| for _, k, v := itr.Next(); k != 0; _, k, v = itr.Next() { | |||
| out.Count++ | |||
| out.Sum += v.(float64) | |||
| out.Mean += (v.(float64) - out.Mean) / float64(out.Count) | |||
| } | |||
| return out | |||
| } | |||
|
|
|||
| type meanMapOutput struct { | |||
| Count int | |||
There was a problem hiding this comment.
@toddboom i had a question about this... should Count be a float64? everywhere it gets used (except for where it's calculated) it gets cast to float64 and i don't know go well enough to know what is more idiomatic.
There was a problem hiding this comment.
I think leaving count as an integer makes sense to me. I don't think the cast is particularly expensive, so I'd leave it that way for now unless you feel strongly otherwise.
There was a problem hiding this comment.
i don't have a strong feeling - only uncertainty - so i'll leave it as is 😃
|
+1 |
toddboom
added a commit
that referenced
this pull request
Apr 22, 2015
add test for large mean aggregations
pauldix
added a commit
that referenced
this pull request
Apr 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2346
this adds a test for calculating mean values where the sum of the values causes an overflow. fix to be pushed to this branch once the tests are confirmed to cause a failure