Do not require snapshot on Log.WriteEntriesTo(). #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where snapshots were always sent when connecting to the leader -- even when not required.
| buf := make([]byte, logEntryHeaderSize+len(e.Data)) | ||
| copy(buf, e.encodedHeader()) | ||
| copy(buf[logEntryHeaderSize:], e.Data) | ||
| if len(l.entries) > 0 { |
There was a problem hiding this comment.
This is just about adding some checks to the code?
There was a problem hiding this comment.
Yes, this is to ensure that Log.entries is always contiguous. A similar check used to exist but was altered with some changes around Log.lastLogIndex
|
+1 |
benbjohnson
added a commit
that referenced
this pull request
Apr 30, 2015
Do not require snapshot on Log.WriteEntriesTo().
|
post-merge +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes a bug where snapshots were always sent when connecting to the leader -- even when not required. This also fixes an issue where
Log.entrieswere not being cleared out on close/open which isn't a problem in practice but can cause issues in tests.