Don't truncate topic data unless fully replicated #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } else { | ||
| // No nodes are replicating this topic, so it's not replicated at all. | ||
| replicatedIndex = 0 | ||
| } |
There was a problem hiding this comment.
You don't need to set it since it defaults to 0 on declaration.
There was a problem hiding this comment.
Ha ha. Of course. D'oh. :-)
|
I'd say remove the |
otoolep
force-pushed
the
wait_for_full_replication
branch
from
610873c
to
b038afa
Compare
|
I had some sort of brain freeze and reverted to C programming. Code changed as per @benbjohnson. Merging on green. |
otoolep
added a commit
that referenced
this pull request
May 8, 2015
Don't truncate topic data unless fully replicated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2521