feat: handle graceful shutdown #26197
Merged
+398
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provides basic wait methods for unix/windows OS's
Added rustdoc comments to types and methods in the influxdb3_shutdown crate as well as a test that shows the ordering of a shutdown.
pauldix
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26175
Provides a new crate
influxdb3_shutdownwhich provides helpers for managing clean process shutdown.wait_for_signalmethod that provides a system dependent future for waiting for aCtrl+CsignalShutdownManagerwhich is used to coordinate application shutdown.This is currently only used in the WAL, where it triggers the WAL shutdown so that the buffer is flushed and responses to waiting requests are returned before exiting the process. Other components than the WAL that need to do cleanup before proper shutdown can utilize this feature.
Future work
The
trigger_shutdownmethod can be used for #26161