Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time literals should use single quotes in String representation #2804

Merged
merged 2 commits into from
Jun 11, 2015

Conversation

nathanielc
Copy link
Contributor

I am using the influxql package to parse an generic query and add a specific time clause to the query. Since a TimeLiteral needs single quotes when parsed I have updated the String representation to also use single quotes as well as the test cases.

@otoolep
Copy link
Contributor

otoolep commented Jun 9, 2015

@beckettsean, @dgnorton -- any comment?

@beckettsean
Copy link
Contributor

+1 from me. Timestamps as strings should be in single-quotes to be consistent with strings elsewhere. Double-quotes should only be for identifiers.

@pauldix
Copy link
Member

pauldix commented Jun 11, 2015

Yep, agree. Thanks!

pauldix added a commit that referenced this pull request Jun 11, 2015
Time literals should use single quotes in String representation
@pauldix pauldix merged commit a2488ab into influxdata:master Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants