Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OpenTSDB to service #2823

Merged
merged 1 commit into from
Jun 8, 2015
Merged

Conversation

benbjohnson
Copy link
Contributor

Overview

This pull request converts the OpenTSDB server into a service and adds some tests.

if p.Time < 10000000000 {
ts = time.Unix(p.Time, 0)
} else {
ts = time.Unix(p.Time/1000, (p.Time%1000)*1000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we are converting to ms here? But a comment to clarify would be helpful.

@corylanou
Copy link
Contributor

+1 on green build.

@otoolep
Copy link
Contributor

otoolep commented Jun 8, 2015

I also reviewed this code, particularly to see if it had implications for #2799. The WaitGroup handling here seems OK, so +1 from me.

@otoolep
Copy link
Contributor

otoolep commented Jun 8, 2015

Obviously +1 on a green build, as per @corylanou

@benbjohnson benbjohnson force-pushed the opentsdb branch 4 times, most recently from 37006dc to 2e3d5f2 Compare June 8, 2015 19:38
@otoolep
Copy link
Contributor

otoolep commented Jun 8, 2015

I don't where the PointsWriter is supplied to this service, by the production code.

if err := h.PointsWriter.WritePoints(&cluster.WritePointsRequest{
Database: h.Database,
RetentionPolicy: h.RetentionPolicy,
ConsistencyLevel: cluster.ConsistencyLevelOne,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks hardcoded. Does this mean clients will have no control over consistency level with openTSDB?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to convert the old server over to a service right now. We can add consistency level separately.

This commit converts the OpenTSDB endpoint into a service.
@benbjohnson
Copy link
Contributor Author

@otoolep Ah, damn, good catch. Fixed in b688ecc.

@otoolep
Copy link
Contributor

otoolep commented Jun 8, 2015

OK, let's get it in. Thanks for the final changes.

benbjohnson added a commit that referenced this pull request Jun 8, 2015
@benbjohnson benbjohnson merged commit a965728 into influxdata:master Jun 8, 2015
@benbjohnson benbjohnson deleted the opentsdb branch June 10, 2015 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants