-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary timeout in WaitForLeader() #3256
Conversation
CircleCI failure, I kicked the build. |
This build failure seems real, and I believe the code needs further work. |
If the timer expires and a leader is still not selected, the local data node will never be created.
dc29f99
to
c41ef86
Compare
It's strange I can build the prior code successfully. The tests should pass this time. |
Thanks @cannium @benbjohnson -- does this make sense to you? |
this is roughly the fix i had that resolved #3205 for me |
@nstott yep, same problem. |
@otoolep yes, this makes sense. I think the timeout was only meant to be temporary. |
OK, thanks @benbjohnson -- merging now. |
Thanks @cannium |
Remove unnecessary timeout in WaitForLeader()
Cherry-picked to 0.9.2. |
If the timer expires and a leader is still not selected, the local data node will never be created.