Fix parse stuck in loop causing 500 timeout #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a 1-line explanation of why this works? |
|
Updated PR description. |
|
+1 |
jwilder
added a commit
that referenced
this pull request
Jul 21, 2015
Fix parse stuck in loop causing 500 timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
points.Fields()func would would get stuck in a scanning loop innewFieldsFromBinary()because the original fields section of the input was not parsed correctly.skipWhitespacewould skip over escape chars when it should only skip over whitespace. It resulted in the fields section sometimes being set=1instead of\a=1. The=1value cause the infinite loop innewFieldsFromBinary()Fixes #3411