add WAL recovery #3717
Merged
add WAL recovery #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,9 @@ const ( | |||
| // MetaFileExtension is the file extension for the log files of new fields and measurements that get created | |||
| MetaFileExtension = "meta" | |||
|
|
|||
| // CompactionExtension is the file extension we expect for compaction files | |||
| CompactionExtension = "CPT" | |||
There was a problem hiding this comment.
Capitals looks funny for file extensions. :-)
There was a problem hiding this comment.
So should we change it @pauldix? It is an NYC thing? :-)
There was a problem hiding this comment.
I don't really have a preference. I used meta for the metadata extension and some people would argue that having something other than a 3 letter extension is blasphemy.
There was a problem hiding this comment.
I don't really care. It's a temporary file anyway so it only exists momentarily. I say just leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit adds recovery for the
engine/wal. It handles removal of segment files that have been written to the WAL but failed before removal. It also renames the compaction file before initializing the partition./cc @pauldix