Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When stopping service, wait until actually exited #3980

Merged
merged 2 commits into from
Sep 4, 2015
Merged

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 3, 2015

Fixes issue #3548.

@otoolep otoolep added this to the 0.9.4 milestone Sep 3, 2015
@otoolep otoolep self-assigned this Sep 3, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Sep 3, 2015

@toddboom

@otoolep
Copy link
Contributor Author

otoolep commented Sep 3, 2015

Tested on a DO droplet.


sleep 1
n=$(expr $n + 1)
echo $n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for anything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good man, debug -- let me remove it.

@otoolep otoolep force-pushed the wait_for_exit branch 2 times, most recently from 0bb9bea to ba76cc5 Compare September 4, 2015 15:58
@otoolep
Copy link
Contributor Author

otoolep commented Sep 4, 2015

Debug code removed @jwilder

@jwilder
Copy link
Contributor

jwilder commented Sep 4, 2015

👍

otoolep added a commit that referenced this pull request Sep 4, 2015
When stopping service, wait until actually exited
@otoolep otoolep merged commit e89978e into master Sep 4, 2015
@otoolep otoolep deleted the wait_for_exit branch September 4, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants