Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats to PointsWriter #4045

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Add stats to PointsWriter #4045

merged 1 commit into from
Sep 9, 2015

Conversation

otoolep
Copy link
Contributor

@otoolep otoolep commented Sep 8, 2015

No description provided.

@otoolep
Copy link
Contributor Author

otoolep commented Sep 8, 2015

@jwilder

@corylanou
Copy link
Contributor

Looks good, should still have @jwilder take a look to confirm the stats line up with what we think they do.

statWritePartial = "write_partial"
statWriteTimeout = "write_timeout"
statWriteErr = "write_error"
statWritePointHHReq = "point_hh_req"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point_req_hh instead? To match the other 3 patterns.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good.

@jwilder
Copy link
Contributor

jwilder commented Sep 9, 2015

One question but 👍 otherwise.

otoolep added a commit that referenced this pull request Sep 9, 2015
@otoolep otoolep merged commit 78f4a69 into master Sep 9, 2015
@otoolep otoolep deleted the writer_stats branch September 9, 2015 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants