Allow filtering SHOW MEASUREMENTS by regex #4501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| &Query{ | ||
| name: `show measurements using WITH and regex`, | ||
| command: "SHOW MEASUREMENTS WITH MEASUREMENT =~ /[cg]pu/", |
There was a problem hiding this comment.
How about a test where the regex shouldn't match anything?
|
Seems fine, though I think it could do with one more test. +1 on adding that extra test (unless I am missing something). |
dgnorton
added a commit
that referenced
this pull request
Oct 19, 2015
Allow filtering SHOW MEASUREMENTS by regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the results of
SHOW MEASUREMENTSto be filtered by regular expression. For example, the following query would return all measurements that begin withcpu: