raft.raftLayer already closed in raft.NetworkTransport.Close() #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me, looking at the hashicorp code and ours. |
| @@ -209,11 +209,6 @@ func (r *localRaft) close() error { | |||
| r.transport = nil | |||
| } | |||
|
|
|||
| if r.raftLayer != nil { | |||
There was a problem hiding this comment.
Can you add a comment to the block above, stating that that Close() will close the raftLayer()?
|
Thanks @oiooj |
|
CLA has been signed. |
|
+1 |
|
LGTM. 👍 |
otoolep
added a commit
that referenced
this pull request
Nov 9, 2015
raft.raftLayer already closed in raft.NetworkTransport.Close()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix functionality panics: close of closed channel
fix #4707
https://github.com/hashicorp/raft/blob/master/net_transport.go#L174