fix TestCluster_OpenRaft is timeout #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mei-rune
changed the title
|
@runner-mei Why not use |
|
TCPConn.Close() is better, but it will result in repeated calls to close, so errors buffer size must is 2. |
|
Thanks @runner-mei -- would you mind squashing the commits? |
|
Seems reasonable, +1 from me once squashed. |
This bug is produce by tcp buffer, must flush tcp stream after the copy L53, but Flush is not exists in the net.TcpConn struct.
|
👍 |
|
Thanks @runner-mei -- hoping this clears up a bunch of testing failures. |
otoolep
added a commit
that referenced
this pull request
Nov 23, 2015
fix TestCluster_OpenRaft is timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4853
This bug is produce by tcp buffer, must flush tcp stream after the copy L53, but Flush is not exists in the net.TcpConn struct.