Graphite: prefer more specific template over default template when possible #5182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -602,6 +602,27 @@ func TestApplyTemplateSpecific(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // Test that most specific template is N/A | |||
There was a problem hiding this comment.
Does this mean that "the most specific template is not applicable? not applied? doesn't matter?" The comment is a little ambiguous.
There was a problem hiding this comment.
Ahem, the first match should be applied in this case. However, it goes deeper to find a more specific one, but cannot find it. The original result will roll back to the global default template, not the first match.
|
@flisky -- have you signed the CLA? |
|
Yes. I'm the guy who contributes #4807. |
|
Ah yes, I remember that PR. Thanks. On Monday, December 21, 2015, 尹吉峰 notifications@github.com wrote:
|
jwilder
changed the title
jwilder
added a commit
that referenced
this pull request
Feb 8, 2016
Graphite: prefer more specific template over default template when possible
|
Thanks @flisky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.