Fix a panic when a tag value was empty #5370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-5262-panic-on-empty-tag-value
branch
from
5790af9
to
690df18
Compare
|
👍 |
jsternberg
force-pushed
the
js-5262-panic-on-empty-tag-value
branch
from
690df18
to
7b7db6e
Compare
A panic would happen if you wrote the following:
cpu,host=
There was a missing bounds check when scanning the tag value.
Fixes #5262.
jsternberg
force-pushed
the
js-5262-panic-on-empty-tag-value
branch
from
7b7db6e
to
8eac790
Compare
jsternberg
added a commit
that referenced
this pull request
Jan 18, 2016
…alue Fix a panic when a tag value was empty
|
When I wrote this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A panic would happen if you wrote the following:
cpu,host=
There was a missing bounds check when scanning the tag value.
Fixes #5262.