Skip backup directories created by influx_tsm #5471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -310,6 +310,10 @@ func (s *Store) loadIndexes() error { | |||
| s.Logger.Printf("Skipping database dir: %s. Not a directory", db.Name()) | |||
| continue | |||
| } | |||
| if strings.HasSuffix(db.Name(), ".bak") { | |||
There was a problem hiding this comment.
Hmm. It's valid to create a db named foo.bak though.
|
This is the wrong answer, the correct solution is in a separate pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should correct the behavior seen in #5469. The databases and backups were getting indexed separately, but once the shards are loaded, the backup file seemed to win and took precedence. Regardless, we shouldn't have been loading the backup directories anyway.