Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable golint on the tsdb/engine/wal #5550

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

gabelev
Copy link
Contributor

@gabelev gabelev commented Feb 5, 2016

Cleaned up tsdb/engine/wal.go and wal_test.go to enable golint per issue #4098.

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

@e-dard
Copy link
Contributor

e-dard commented Feb 8, 2016

@gabelev can you update the CHANGELOG?

@gabelev
Copy link
Contributor Author

gabelev commented Feb 8, 2016

@e-dard: done.

@@ -243,6 +245,7 @@ func (l *Log) Open() error {
return nil
}

// DiskSize will returns the current size of a Log file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: returns -> return

@corylanou
Copy link
Contributor

One minor nit. Otherwise +1. Will need a rebase as well. Thanks!

@gabelev gabelev force-pushed the lint_engine_wal branch 3 times, most recently from c207f44 to a670ec4 Compare February 8, 2016 22:11
@gabelev
Copy link
Contributor Author

gabelev commented Feb 8, 2016

@corylanou: made the small fix. rebased on master.

@e-dard
Copy link
Contributor

e-dard commented Feb 8, 2016

@gabelev needs another rebase

@gabelev
Copy link
Contributor Author

gabelev commented Feb 9, 2016

@e-dard: ok. rebased again.

e-dard added a commit that referenced this pull request Feb 9, 2016
Enable `golint` on the tsdb/engine/wal
@e-dard e-dard merged commit 142ff66 into influxdata:master Feb 9, 2016
@gabelev gabelev deleted the lint_engine_wal branch February 9, 2016 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants