Remove MetaServers from node.json #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta HTTP commands are cluster level requests and were showing up in the main log creating a lot of noise. Switch them to use the ClusterTracing config option which is disabled by default.
6 tasks
| if err != nil { | ||
| if !os.IsNotExist(err) { | ||
| return nil, err | ||
| } else { | ||
| node = influxdb.NewNode(c.Meta.Dir, metaAddresses) | ||
| node = influxdb.NewNode(c.Meta.Dir) |
There was a problem hiding this comment.
Feels like there is some future refactoring here yet. I'm not sure what purpose a node without a valid ID really serves. Just thinking out loud on this one. No action needed at this time.
|
Changelog then +1 |
This removes the MetaServers property from node.json to eliminate one of the four places those addresses are stored on disk. We always use the values that come through the config (via file, env var or -join arg).
|
LGTM 👍 |
jwilder
added a commit
that referenced
this pull request
Feb 16, 2016
Remove MetaServers from node.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the MetaServers property from node.json to eliminate one
of the four places those addresses are stored on disk. We always use
the values that come through the config (via file, env var or -join arg) to
simplify the server bootstrapping code.
Part of work to complete #5673